Add support for Python's "Limited API"; Test cibuildwheel and py >=3.5 using TestPythonSML.py
#461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reduced from 24 files to 5 :) |
ShadowJonathan
commented
May 16, 2024
|
Note to self for later: there appears to be non-determinism in this test that randomly failed on Windows: testSpreadingActivation_AlphabetAgentAllOn: ✅ 😈 Ha! Assert: testSpreadingActivation_AlphabetAgentAllOn halted too early. Letters were likely skipped. DC = 1583 |
ShadowJonathan
changed the title
TestPythonSML.py
|
I've added extra changes which now addresses #460, per the review comment. |
|
Just had one last tiny comment. Very excited to merge this! Thank you for all your work! |
|
Actually I can take care of that comment. I'll go ahead and merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #458
Resolves #460
This pivots scons to build for a single "limited API" that stays future-proof for all python 3 versions, following a single one it is built for.
This also tests all those versions that it is then supporting. This is done in parallel, so that it impacts CI times minimally. (and adds 30 seconds max)
This'll only build the
abi3wheels ifSOAR_PYTHON_ABI3is defined at the time of building. The output wheels are appropriately tagged, so that version mixing does not happen.(This environment variable makes the building of
abi3wheels completely optional, python-version-specific wheels will be created without it (like before), which should be alright for development installs and the likes)This PR also has cibuildwheel call and run
TestPytonSML.pyto more thoroughly test its wheels.This change is also added to the above OS+PyVersion testing matrix.